Closed Ereaey closed 1 month ago
I think this is a great idea!
I would envision an implementation that uses the existing /api/v1/admin/config
endpoint to return fields like isLdapConfigured
, isGoogleOauthConfigured
etc. And then render the sign-in options depending on which are configured.
@dangtony98, what do you think of this?
@DanielHougaard yes, this is a great idea
I don't know if we can add it to this request but deactivating authentication by email (using an environment variable to avoid problems in production in the event of an SSO problem) could be useful also to force the use of sso.
I don't know if we can add it to this request but deactivating authentication by email (using an environment variable to avoid problems in production in the event of an SSO problem) could be useful also to force the use of sso.
I would add a separate proposal for that. This is a lower priority than hiding unconfigured SSO login methods though.
Hi everyone, I was thinking of conditional rendering the Login UI based on the env variables. Will check if the env variable values are not empty and then based on that render the signIn options?
Something like this fix in the InitialSignupStep.tsx would conditionally render the SignIn options based on the creds. Do let me know if this is a right direction to proceed with or any other approach is required.
Anyone working on this? If not please assign it to me, I'll do it
Hi @Vishvsalvi,
Thank you, I'll assign the issue to you!
Please check this small proposal for how I would envision the implementation to look like
This feature is already released. You can control auth methods for your instances via the admin panel
Please close it if that's the case
Feature Description
Currently, all Single Sign-On (SSO) options are displayed on the homepage, including those that are not configured. The feature should ensure that only configured and operational SSO options are visible to users. Unconfigured SSO options should not appear on the homepage to avoid confusion and unsuccessful login attempts.
Why Would It Be Useful?
This feature would improve user experience by displaying only relevant and functional login methods, making the login process clearer and faster. It would also reduce technical support queries from users attempting to use unconfigured SSO methods. Additionally, it would enhance the overall usability and professionalism of the Infisical platform by preventing user frustration and potential security concerns.
Additional Context
This adjustment requires changes in both the SSO configuration management system and the homepage's UI rendering logic. Considerations need to be made for:
Implementing this feature would involve checks during the homepage loading process to determine which SSO methods are configured and modifying the UI to display only those methods.