search

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
15.43k stars 928 forks source link

Change Notification Library from react-toastify to Notistack #2533

Closed moizsheraz closed 3 weeks ago

moizsheraz commented 3 weeks ago

Feature Description

Change the notification library in Infisical from react-toastify to Notistack in the frontend/src/components/notifications/Notifications.tsx file.

Why Would It Be Useful?

Notistack provides a more modern and visually appealing notification experience, with better customization and management options.

Additional Context

react-toastify feels ordinary, and switching to Notistack could enhance user engagement . More info on Notistack can be found here.

moizsheraz commented 3 weeks ago

@maidul98 I would like to take on the implementation of this feature.

akhilmhdh commented 3 weeks ago

@moizsheraz react-toastify has been working great for us.

I don't understand what you mean by better notification experience. Something that has been working quite fine why would we change it? Also react-toastify is much mature than notistack both in terms downloads and usage. We are keeping old version of it due to nextjs issue.

Moving to discussion for time being as this more of a discussion rather than issue