Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI

https://infisical.com

Other

15.73k stars 985 forks source link

misc: address role slug issue in invite user endpoint #2748

Closed sheensantoscapadngan closed 6 days ago

sheensantoscapadngan commented 6 days ago

Description 📣

This PR ensures that if roleSlugs is defined during user project invite, the roles are actually assigned correctly

Type ✨

[x] Bug fix
[ ] New feature
[ ] Improvement
[ ] Breaking change
[ ] Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

[x] I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

DanielHougaard commented 6 days ago

Actually this in theory a breaking change. If someone is passing in an empty array for the roles, their workflow will break. As I see it, this is not how the endpoint is intended to be used in the first place though. Either the user should pass in an array with items, or pass nothing at all.

Question is, are we okay with adding this potentially breaking change? I am personally okay with it, as the risk appears low