Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
15.73k stars 985 forks source link

Secret Scanning: 'Integrate with GitHub' Button Fails Without User Feedback #2783

Open Mhammad-riyaz opened 20 hours ago

Mhammad-riyaz commented 20 hours ago

Describe the bug

In the secret scanning tab, the "Integrate with Github" button is not working.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to the Secret Scanning tab.
  2. Click on the "Integrate with GitHub" button.
  3. Observe that no toast or actionable feedback is provided, and the integration does not proceed.

Expected behavior

Clicking on the "Integrate with GitHub" button should: Provide user feedback, such as a toast or notification, indicating the status of the integration.

Screenshots

image image

Additional context

Clicking the button triggers the createNewIntegrationSession function. This function sends a request to the backend endpoint registerSecretScanningRouter. The backend checks if the organization ID is listed in SECRET_SCANNING_ORG_WHITELIST. If the ID is not whitelisted, the backend returns a 400 Bad Request with a message saying that Secret scanning is temporarily unavailable. As a result, createNewIntegrationSession returns undefined, causing the error. No feedback is provided to the user regarding this failure.