Infisical / infisical

ā™¾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
15.77k stars 988 forks source link

Fix Error When Clicking on CA Table Row After Viewing Certificate in Certificate Authorities Tab #2787

Open Mhammad-riyaz opened 4 days ago

Mhammad-riyaz commented 4 days ago

Description šŸ“£

Fixes #2786

This pull request addresses a bug in the Certificate Authorities section where clicking on a CA table row after selecting View Certificate results in a page error.

Root Cause The issue arises due to two hooks, useGetCaCerts and useGetCaCert, which are both using the same query key ("ca-cert") for fetching data:

useGetCaCerts: Called when clicking on a CA table row, it fetches an array of objects. useGetCaCert: Called when clicking on the three dots and selecting View Certificate, it fetches a single object.

Since both hooks are using the same query key, the cache will store only the most recent data fetched. On clicking on View Certificate the useGetCert hook is called which returns an object and this is stored in the cache, and now on clicking on the row (CA), the component tries to map over the data, since the object is in cache ,it cannot map over it resulting in the error.

Solution The query key for useGetCaCerts has been updated from "ca-cert" to "ca-certs", ensuring that the two hooks use distinct cache keys and no longer conflict.

Type āœØ

Tests šŸ› ļø

getCaCerts: (caId: string) => [{ caId }, "ca-certs"],