search

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
13k stars 677 forks source link

Tags should be an array #396

Open jon4hz opened 1 year ago

jon4hz commented 1 year ago

Feature description

Hi, I didn't dig to deep into the api yet but from what I see, the tags are currently treated as a single string.

https://github.com/Infisical/infisical/blob/99144143ff2f3955e38f398af27d954f3c5e348e/cli/packages/api/model.go#L200

Shouldn't that field be a string array?

Why would it be useful?

Makes the API a bit cleaner.

maidul98 commented 1 year ago

It's a list of strings separated by commas such as tags1,tags2,tags3. I agree making it a list and then converting the list to a comma separated list may be more initiative