search

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
12.97k stars 672 forks source link

[CHORE] Fix configuration variables mismatches 🏷️ #416

Open Grraahaam opened 1 year ago

Grraahaam commented 1 year ago

Feature description

While setting up a local development environment (compose/k8s), I've encountered some variable mismatches listed below :

Check if all those configuration variables are documented in the docs :

Let me know if you find another configuration variable mismatch in order to fix it asap, I'll try to update the above list accordingly

Why would it be useful?

Improve visibility on Infisical's self-hosting configuration

vmatsiiako commented 1 year ago

@maidul98 I think you were working on environment variables recently?

dangtony98 commented 1 year ago

Hmm I see this as well @maidul98 is there any reason why SITE_URL is harded to app.infisical.com?

I'll look into this TELEMETRY_CAPTURNG_ENABLED thing as well. Thanks @Grraahaam, I'm in the process of reviewing the envars and adding the new Infisical Node SDK.

maidul98 commented 1 year ago

It was hard coded as a quick patch to a issue in prod a while back. We will need to make it dynamic using Egi's script for frontend

dangtony98 commented 1 year ago

I think we should remove/deprecate as many envars as possible on the frontend and move them to backend. Next.js is known to not support well envars at runtime (only buildtime which is the cause of some of our historic issues with frontend envars).

For example, we have envars related to POSTHOG and STRIPE that could totally be moved to the backend (the STRIPE envars will be soon deprecated entirely as we build out a license server system in the future anyways). All this would put less headspace for people to have to input any envars for the frontend.

I noticed also that we have INFISICAL_TELEMETRY_ENABLED=${TELEMETRY_ENABLED} listed in the Docker compose file for the frontend but we don't consume INFISICAL_TELEMETRY_ENABLED anywhere.