Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
13.16k stars 698 forks source link

Change 6-digit code to an email link during signup #58

Open vmatsiiako opened 1 year ago

vmatsiiako commented 1 year ago

Feature description

During signup, users get an email with a 6-digit code that they later need to copy and paste into the next signup step. Ideally, we would not to substitute it to an email link that people click and it automatically opens up the next signup step (after verifying that the link is correct).

Why would it be useful?

Links are both more secure and effortless than 6-digit codes. This would be very good to have!

khoa165 commented 1 year ago

@vmatsiiako hi Vlad, I am new to OSS contributing, hoping to pick up my first issue. Do you know if this has been done yet?

vmatsiiako commented 1 year ago

hey @khoa! Excited for you to join our community and hopefully contribute to Infisical. You should also consider joining our Slack for contributors. Here is the link: https://infisical.com/slack

I think this would be a great issue. I'd love to hear what @dangtony98 thinks about it too.

khoa165 commented 1 year ago

@vmatsiiako do you know how I can setup the email/SMTP? I used to just use my own personal gmail/password and put it in .env file. However, Google recently disabled/deprecated the ability to allow for less secure app access, so I am not sure if there is alternative or if there is shared email account from Infisical for this purpose.

Screenshot 2023-06-19 at 2 16 57 PM
vmatsiiako commented 1 year ago

I see. @dangtony98 do you have any ideas for how we could get around this?

I think you might be able to sue the free version of sendgrid

khoa165 commented 1 year ago

@vmatsiiako from what I just dig around, sendgrid seems to offer SMTP server instead of giving you a free email. Specifically, I think I am looking for maybe alternative of what I should populate these fields in .env with:

SMTP_HOST=Gmail
SMTP_PORT=
SMTP_NAME=
SMTP_USERNAME=dev.khoa165@gmail.com
SMTP_PASSWORD=[my email password]

I made sure to put the correct email/password yet it did not send me the email for 6-digit code (step 2 of signup)

maidul98 commented 1 year ago

If you want to configure SMTP for local development, you can simply use the mailhog details below to your .env

SMTP_HOST=smtp-server
SMTP_PORT=1025
SMTP_NAME=<whatever you like>
SMTP_USERNAME=team@infisical.com
SMTP_PASSWORD=

All mail will then be sent here http://localhost:8025/

dangtony98 commented 1 year ago

@khoa165 You should read the documentation we have for configuring Infisical with various email providers here: https://infisical.com/docs/self-hosting/configuration/email

We support SendGrid, AWS SES, Mailgun, and a number of other confirmed providers if you wish to set up emailing outside of the development mailing server :)

khoa165 commented 1 year ago

Ahhhh @dangtony98 thanks for the info. I was just trying to do local development and the variables that Maidul provided are working for me.