Warning message in integration provider connect modal

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI

https://infisical.com

Other

14.94k stars 840 forks source link

Warning message in integration provider connect modal #691

Open akhilmhdh opened 1 year ago

akhilmhdh commented 1 year ago

Feature description

As requested by one of our user, it would be great to put a small warning message in the provider connection screen that tells user: The existing secrets will be removed and infisical provided ones will get replaced.

Why would it be useful?

Good user experience

Additional context

This needs to be added below title of all the screens of providers. Like

/pages/heroku/create
/pages/vercel/create

Ref UI:

Screenshot 2023-06-28 at 11 03 34 AM

Something like above after title

dragonRageX commented 1 year ago

Hi, it's my first time solving bugs... How do I get started? Are there any docs that I can go through before I can get started?

abhithory commented 1 year ago

hi @akhilmhdh, I am interested in solving this issue. can you please assign me?

akhilmhdh commented 1 year ago

Hey there @dragonRageX you can read the contribution guide to help you get started. Also join our slack space to get your ans to any doubts.

akhilmhdh commented 1 year ago

@dragonRageX are you planning to work on this, or should i assign this to @abhithory

dragonRageX commented 1 year ago

@dragonRageX are you planning to work on this, or should i assign this to @abhithory I'm going through the docs for now... by the time, you can assign him this issue.

akhilmhdh commented 1 year ago

Thank you @dragonRageX

hey @abhithory are you still interested in working on this issue. Then I can assign it to you.

abhithory commented 1 year ago

@akhilmhdh , yes please

abhithory commented 1 year ago

hello @akhilmhdh , i have added this warning message. Please check it and let me now if it is okay?? should i make PR of it?

Also i want to ask one thing

I have to stop the server and start it again every time to see new updated changes in the frontend. without it, it is not showing updated pages. why is that?? or is it only with me??

lokesh3097 commented 10 months ago

Hi @abhithory! Is there any update from you regarding this issue? Can I take it up if you aren't working anymore on this?

abhithory commented 10 months ago

@lokesh3097 , yes sure

abhithory commented 10 months ago

i wanted to confirm from them the design, but they have not responed anything

lokesh3097 commented 10 months ago

Hi @akhilmhdh! Can I take up this issue?

maidul98 commented 10 months ago

@abhithory your design looks good to me. I think it would look better if warning was put right above the create integration button instead. Either @abhithory or @lokesh3097 please make a PR for it and we will get it reviewed

lokesh3097 commented 10 months ago

@abhithory your design looks good to me. I think it would look better if warning was put right above the create integration button instead. Either @abhithory or @lokesh3097 please make a PR for it and we will get it reviewed

@abhithory If you have the code ready please feel free to raise a PR as you might have already worked on it. If not please let me know.