Infiziert90 / ChatTwo

European Union Public License 1.2
22 stars 19 forks source link

Auto-Scrolling breaks with some Dalamud Styles #85

Closed zbee closed 4 months ago

zbee commented 4 months ago

My chat2 no longer scrolls with chat messages since yesterday, and has no errors in the logs.

I've tried:

zbee commented 4 months ago

The problem is with Dalamud styles, a spacing issue. Going to work through the Style Editor's variable list and pinpoint which it is.

zbee commented 4 months ago

CellPadding Y value > 4 breaks auto-scroll.

Changing this comparison to check for MaxY - 16 fixes this issue without truly affecting other sizes; though it will auto-scroll you down if you release the scrollbar less than 1 full message's height upwards from being 100% scrolled down. 16 because 4 is the default Dalamud CellPadding, and 20 is the max. I don't see a more obvious or a possibly functional and more correct fix, but I am not so familiar with ImGui still.

I'll PR this, in the case that no other fixes present themselves to you.