Infiziert90 / Hunty

MIT License
7 stars 8 forks source link

Extended logbook spanning all classes #7

Closed Varstahl closed 11 months ago

Varstahl commented 11 months ago

Hello o/

I took a stab at solving an old gripe of mine, which is to get hunt information as readily available as possible. I noticed that some of the hunt data for a handful of mobs was incomplete as they're available in multiple areas, so I've slightly expanded the locations.

Additionally, I've compacted the data, sorted it out a bit, and showed it for every class, so that you can see at a glance all the needed hunts and the class that needs them.

And finally, the list automatically updates on territory change too, so the window truly feels like a companion showing you updated data based on where you are.

This has served me well already all throughout La Noscea, hope you can find this useful.

Notes

  1. The additional locations in the monsters.json shouldm't have any impact, since the default getters use `Locations[0]ˆ.
  2. I think the xl windows is bugged, since it doesn't show the grand company hunts. If it's by design, then that code portion can be removed.
  3. Some of the Grand Company hunt monster areas are missing, like the Amalj'aas, but since there are alternative locations it shouldn't be too big of a deal.
  4. I think my draw loop is somewhat wasteful. There's a little bit too much computation for my taste, but on my machine I didn't see excessive strain so for the moment I didn't cache much, if anything at all.
  5. I'm kinda new to C# / ImGui, but I think I did a decent job with this one.
Infiziert90 commented 11 months ago

Thank you for the PR :)

I think the xl windows is bugged, since it doesn't show the grand company hunts. If it's by design, then that code portion can be removed.

And no, this is by design, as i expect people to have finish GC stuff or focused on it, long before they try to do other classes, so i saw it as not important for the XL window