search

InflationX / Calligraphy

Custom fonts in Android the easy way...
Apache License 2.0
1.09k stars 83 forks source link

upgrade Calligraphy for viewpump:2.0.0 #19

Closed Ali72 closed 5 years ago

Ali72 commented 5 years ago

please upgrade Calligraphy for match with io.github.inflationx:viewpump:2.0.0

jbarr21 commented 5 years ago

I don't believe we've broken any APIs. Could you please be more specific with the issue that you are encountering?

jameswald commented 5 years ago

One issue is that Calligraphy can't access ViewPump's ReflectionUtils:

Screen Shot 2019-04-09 at 4 44 56 PM

This seems to be an issue with ViewPump 1.0.0 too, though.

jbarr21 commented 5 years ago

@jameswald ah, yes, looks like https://github.com/InflationX/ViewPump/pull/25 made this internal. seems reasonable to duplicate instead of depending on internals of another lib

ZacSweers commented 5 years ago

I'll PR a fix later today if someone else doesn't get around to it first

flo5324 commented 5 years ago

Proguard also raise warning on this ReflectionUtils class I imagine that when this class will be duplicated in Calligraphy, this will no longer appear ?

Warning: io.github.inflationx.calligraphy3.Calligraphy: can't find referenced class io.github.inflationx.viewpump.ReflectionUtils Warning: io.github.inflationx.calligraphy3.Calligraphy: can't find referenced class io.github.inflationx.viewpump.ReflectionUtils Warning: io.github.inflationx.calligraphy3.Calligraphy: can't find referenced class io.github.inflationx.viewpump.ReflectionUtils

Calligraphy 3.3.0 ViewPump 2.0.1