search

InflationX / ViewPump

View Inflation you can intercept.
Apache License 2.0
899 stars 61 forks source link

Consumer ProGuard rules are bad #35

Closed JakeWharton closed 5 years ago

JakeWharton commented 5 years ago

As far as I can tell, this library does reflection but not on any of its own types. It's unclear why you are shipping ProGuard rules that retain the entire library, prevent it from being optimized, and prevent it from being obfuscated. Please remove the rules or make an effort to craft the narrowest rules that retain only what's needed.

jbarr21 commented 5 years ago

Ah, thanks for catching this. It must've been an oversight from when it was migrated out of Calligraphy. I'll take a look at this

JakeWharton commented 5 years ago

I'm happy to also help narrow them down if I can in any way. Normally I'd just send a PR but it's late and I'm not actually a user of the library. Just passing by it inside of someone else's APK.

On Fri, Mar 29, 2019, 1:11 AM James Barr <notifications@github.com wrote:

Ah, thanks for catching this. It must've been an oversight from when it was migrated out of Calligraphy https://github.com/chrisjenx/Calligraphy/blob/master/calligraphy/consumer-proguard-rules.txt. I'll take a look at this

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/InflationX/ViewPump/issues/35#issuecomment-477869897, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEVKKPZOsEvMlj5p89XIi3W0MdP65ks5vbaCVgaJpZM4cRn-p .

ZacSweers commented 5 years ago

yeah these probably carried over from the original calligraphy version and just "adapted" copying them with the viewpump package 😅