Infleqtion / client-superstaq

https://superstaq.readthedocs.io
Apache License 2.0
84 stars 19 forks source link

lazy-load qss backend configuration #1010

Closed richrines1 closed 1 month ago

richrines1 commented 1 month ago

fixes #772

bharat-thotakura commented 1 month ago

Should we revert https://github.com/Infleqtion/client-superstaq/pull/892/commits/1f953b0ca01fc19b907e4a889d846beaf9333e0e after merging this PR?

richrines1 commented 1 month ago

Should we revert 1f953b0 after merging this PR?

ah good question. ~i think the first change in that commit should be reverted (and is small enough that i'll just add it to this pr)~. i kinda feel like the others are maybe nicer as they are though? imo the get_targets output is more interesting/informative than showing the output of backends() now.. wdyt?

edit: oops just noticed re: the first change that that commit was purely additive, so maybe nothing would have to be reverted?

bharat-thotakura commented 1 month ago

^ Yeah sure, I'd agree with that and I guess it keeps both the css and qss notebook outputs (w.r.t. targets output) the same. And yes, if we're keeping the get_targets() output, nothing needs to be reverted