search

InfluxCommunity / influxdb-ruby

Ruby client for InfluxDB
MIT License
370 stars 133 forks source link

Change hash to keyword args using the double splat #243

Closed track8 closed 4 years ago

track8 commented 4 years ago

Change hash to keyword args using the double splat.

influxdb-0.8.0/lib/influxdb/query/core.rb:29: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
influxdb-0.8.0/lib/influxdb/query/core.rb:88: warning: The called method `query_params' is defined here
dentarg commented 4 years ago

@toddboom @dmke would be nice to get this one merged and released too, if you have the time :-) thanks!

toddboom commented 4 years ago

@dentarg Sorry, I haven't had commit rights in quite a while. I think this is all up to @dmke!

dmke commented 4 years ago

Sorry, I'm not very active here anymore.

I'll leave it to @hennevogel and/or @ChrisBr to cut a release :-)

dentarg commented 4 years ago

Thanks for merging! I'll 👀 for that release 🤞

dentarg commented 3 years ago

@hennevogel or @ChrisBr any chance for a new release with this change?

(The change is required to able to run on Ruby 3 that is expected to land around X-mas 🎅)

ChrisBr commented 3 years ago

Thanks for the heads up. I think we can release a new version soon 👍

dentarg commented 3 years ago

@ChrisBr sorry to bother you, but what about that release? 🙇 😆

ChrisBr commented 3 years ago

@ChrisBr sorry to bother you, but what about that release? 🙇 😆

@dentarg sorry for the delay, Travis seems to be broken and there are some more Ruby 3 issues I would like to fix before releasing a new version. I currently can't tell when I will have time to fix it but if you want to give it a stab, go for it.

dentarg commented 3 years ago

@ChrisBr I opened https://github.com/influxdata/influxdb-ruby/pull/249, want to take a look?

ChrisBr commented 3 years ago

Awesome @dentarg! I will have a look tomorrow morning but looks promising.