search

InfluxCommunity / influxdb3-go

The go package that provides a simple and convenient way to interact with InfluxDB 3.
https://pkg.go.dev/github.com/InfluxCommunity/influxdb3-go
MIT License
21 stars 11 forks source link

refactor: change signature of parameters in `Query` function #25

Closed bednar closed 11 months ago

bednar commented 1 year ago

Change order of arguments:

func (c *Client) Query(ctx context.Context, query string, database string, queryParams ...string) (*QueryIterator, error) {
    return c.queryWithType(ctx, database, query, "sql", queryParams...)
}

Rename queryParams to metadata - the query params will be used for parameters in sql query (prepared statement):

func (c *Client) Query(ctx context.Context, query string, database string, metadata ...string) (*QueryIterator, error) {
    return c.queryWithType(ctx, database, query, "sql", queryParams...)
}

https://github.com/InfluxCommunity/influxdb3-go/blob/ef08ba598dbb109197a9667a62931a0c7adade3d/influx/query.go#L68

Sciator commented 1 year ago

Will be fixed in #27