Closed bednar closed 8 months ago
Attention: 46 lines
in your changes are missing coverage. Please review.
Comparison is base (
3cede62
) 83.84% compared to head (8c5ed18
) 82.89%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
please add SetUIntegerField
.
Why use Setter functions here instead of following the convention used by func (c *Client) WriteData{}
which uses field tags? It's not like Values is a private field that would require a setter. Doesn't feel like idiomatic Go code.
type TemperatureSensor struct { Measurement string
lp:"measurement"
Sensor stringlp:"tag,sensor"
ID stringlp:"tag,device_id"
Temp float64lp:"field,temperature"
Hum intlp:"field,humidity"
Time time.Timelp:"timestamp"
Description stringlp:"-"
}
Hi @nrhvyc,
Thank you for your input. Could you please provide more details about your suggestion? I'm not sure I've fully understood what you are proposing. Any additional information you can provide would be helpful.
Best regards
@arukiidou
please add
SetUIntegerField
.
I will update this PR
@nrhvyc, please feel free to suggest improvements to the client. We are always happy to consider changes that will enhance usability for our community. Our minds are open. ;)
Closes #14 Closes #43 Closes #44
Proposed Changes
The user is able to query data into structured object and write this object back to database.
Checklist