Closed alespour closed 4 months ago
Attention: Patch coverage is 92.59259%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 83.09%. Comparing base (
a9da0b1
) to head (f6916ef
).
Files | Patch % | Lines |
---|---|---|
influxdb3/write.go | 83.33% | 4 Missing and 1 partial :warning: |
influxdb3/query.go | 92.30% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Tried new features and some old in ad hoc tests here https://github.com/bonitoo-io/influxdb3-client-tests/tree/main/go-client/release-0.6.0.
While these covered the core of the golden path, nothing unexpected occurred and results look sound.
Nit pick: As mentioned at points in review, the message on deprecated methods can be a bit confusing at first glance. Perhaps it could be improved by being more specific.
For example.
- current: "Deprecated: use Query with WithQueryOptions option"
- suggested: "Deprecated: use Query with variadic QueryOptions option"
The messages are updated.
Closes #55
Proposed Changes
This PR add supports for named parameters in the query API
QueryWithParameters(context.Context, string, QueryParameters, ...QueryOption)
Breaking changes
Changed existing
Query*
andWrite*
methods fromto
where available options are
QueryOption
:WithDatabase
WithQueryType
WriteOption
:WithDatabase
WithPrecision
WithGzipThreshold
WithDefaultTags
Example:
Checklist