QueryType constant should be `SQL` instead of `FlightSQL` - Githubissues

InfluxCommunity / influxdb3-go

The go package that provides a simple and convenient way to interact with InfluxDB 3.

https://pkg.go.dev/github.com/InfluxCommunity/influxdb3-go

MIT License

21 stars 11 forks source link

QueryType constant should be `SQL` instead of `FlightSQL` #70

Closed jstirnaman closed 2 months ago

jstirnaman commented 3 months ago

Because the client uses the (IOx native) Flight RPC API, and not FlightSQL, shouldn't the QueryType be SQL? It makes explaining the distinctions even more confusing--for example:

"native" Flight API and FlightSQL are different APIs built on the same protocol
you can use SQL with this client
you're not using FlightSQL, although the default QueryType here suggests that you are:

https://github.com/InfluxCommunity/influxdb3-go/blob/5bbcc4a45b993a5db7a746475cff6bad8a70f0d4/influxdb3/query_type.go#L30

bednar commented 3 months ago

@jstirnaman you are right, I will fix this inconsistency ASAP