InfluxTimer / sm-timer

Easy to setup, modular bhop/surf/deathrun timer for CSS & CS:GO gameservers.
https://influxtimer.com/
88 stars 26 forks source link

influx_recording.smx handles to high (Memory Leak)? #94

Closed freakexeuLow closed 4 years ago

freakexeuLow commented 5 years ago

Hey Mehis, i have a lot of handles with this plugin, is this normal?

Owner Handles Memory
influx_recording.smx 1751 740068 bytes
kidfearless commented 5 years ago

Prestrafe recording clones an arraylist and doesn't properly close it. Disabling that should reduce the memory leaks.

freakexeuLow commented 5 years ago

Prestrafe recording clones an arraylist and doesn't properly close it. Disabling that should reduce the memory leaks.

Ohh hey Kid, But the Replay Bot won't work after that, will it?

TotallyMehis commented 5 years ago

Hey Mehis, i have a lot of handles with this plugin, is this normal? Owner Handles Memory influx_recording.smx 1751 740068 bytes

That does not look normal. I think I've spotted the issue. Expect a fix soon.

TotallyMehis commented 5 years ago

Try using the dev version of influx_recording.

freakexeuLow commented 5 years ago

Thanks Mehis, problem is gone

freakexeuLow commented 5 years ago

@TotallyMehis

It hasn't gotten any better its now over 31 million leaks (picture below) https://i.imgur.com/j3zHEV5.png

TotallyMehis commented 5 years ago

Is that from a map with a lot of long recordings? 88 handles is reasonable.

freakexeuLow commented 5 years ago

I have other 200 maps on the server so the handles are not the problem, so i mean the leaks are over 31 million. I don't think that's normal.

TotallyMehis commented 5 years ago

You didn't answer my question. Does the map, in which you used the command to show the handle info, have long recordings? If there was a leak, the handle number would go up.

freakexeuLow commented 5 years ago

Oh Sorry and I've completely evaluated this. So this is the site here: https://snksrv.com/tools/sourcemod/handles-analyzer.html

Here is my dumb: https://pastebin.com/0XCtytQK

So I don't think he specifically picks a map in this^^

TotallyMehis commented 5 years ago

That looks normal. You have 65 smaller pre-run recordings and a few larger ones that look like they are record recordings. You can change the max recording length to bring the memory usage down.

freakexeuLow commented 5 years ago

mhh you mean this here? // Max recording length in minutes. // - // Default: "75" influx_recording_maxlength "75"

TotallyMehis commented 5 years ago

Yea