search

InfoSec812 / sonar-auth-google

OAuth2 Authentication Plugin For SonarQube
Apache License 2.0
27 stars 25 forks source link

oAuthDomains can be a list of domains, separated by comma #24

Closed ThYpHo0n closed 5 years ago

ThYpHo0n commented 5 years ago

Hey, we needed to have a list of domains to whitelist, I added the doc and extended the domain check a bit. Unfortunately this doesn't work for the hd OAuth parameter (which limits the UI part on Google to your whitelisted domain).

ThYpHo0n commented 5 years ago

Oh, I just saw that the Travis CI build is using Java 1.7 and therefore doesn't support lambdas /o\ I can create a version without using lambdas if you are interested in merging this feature?

InfoSec812 commented 5 years ago

I am willing to merge this if it will pass CI. Please also bump the version in the POM before submitting.

Cheers,

Deven

On Wed, Jul 17, 2019 at 5:40 AM Niklas Grebe notifications@github.com wrote:

Oh, I just saw that the Travis CI build is using Java 1.7 and therefore doesn't support lambdas /o\ I can create a version without using lambdas if you are interested in merging this feature?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/InfoSec812/sonar-auth-google/pull/24?email_source=notifications&email_token=AAAYK2Y2PNGJX2XW3YO3XO3P73SIRA5CNFSM4IEONAUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DUM4I#issuecomment-512181873, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAYK24YLLVJLG2XNIF3ZWDP73SIRANCNFSM4IEONAUA .

--

Deven Phillips

Senior Consulting Engineer, Open Innovation Labs

Red Hat https://www.redhat.com/

deven.phillips@redhat.com M: 8129685717 https://red.ht/sig

ThYpHo0n commented 5 years ago

Thanks Deven! I applied the needed changes and bumped the version.

InfoSec812 commented 5 years ago

Merged... I will make an announcement on the SonarQube forums about the prep for a new release. It will take a few weeks before it shows up in the Marketplace.

Deven

On Wed, Jul 17, 2019 at 9:12 AM Niklas Grebe notifications@github.com wrote:

Thanks Deven! I applied the needed changes and bumped the version.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/InfoSec812/sonar-auth-google/pull/24?email_source=notifications&email_token=AAAYK25YLJPRYJNYS36IBWLP74LDJA5CNFSM4IEONAUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2EERBI#issuecomment-512247941, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAYK2YMJLQDI3FQBWVLHIDP74LDJANCNFSM4IEONAUA .

--

Deven Phillips

Senior Consulting Engineer, Open Innovation Labs

Red Hat https://www.redhat.com/

deven.phillips@redhat.com M: 8129685717 https://red.ht/sig