Infocaster / UrlTracker

An Umbraco package that tracks 404 not found results and helps you redirect visitors to the right page
https://infocaster.net/wat-we-doen/umbraco-plugins/301-url-tracker
MIT License
17 stars 12 forks source link

Update UI configuration #180

Closed nikcio closed 3 months ago

nikcio commented 3 months ago

Proposed changes

This updates the packages and configuration used for the Backoffice UI.

Generally, it wasn't set up in a working way (at least for prettier) and was using outdated versions, which have now been updated.

This updates the eslint setup to use the recommended setup from here: https://typescript-eslint.io/getting-started/legacy-eslint-setup

I've also replaced the a11y eslint rules as it wasn't registered and targeted JSX which isn't in the UI project. Instead, I've added a Lit-specific a11y rule set.

Notes


@Infocaster/developers

D-Inventor commented 3 months ago

Hi @nikcio !! I love this contribution. I'm very happy to see this.

As I'm more backend focussed, this is going over my head a little bit. I will share this with a coworker to get a second opinion.

I see you updated the uui library and angularjs types. I know that for both of those, we rely on the version that Umbraco supplies. I need to confirm that Umbraco's supplied versions match with your update before I merge this. (The uui version was based on what U10 supplied, but I never checked for U13)

Thank you for this, I will get back to you, hopefully today.

nikcio commented 3 months ago

@D-Inventor The PR has been updated 😄