Infocaster / UrlTracker

An Umbraco package that tracks 404 not found results and helps you redirect visitors to the right page
https://infocaster.net/wat-we-doen/umbraco-plugins/301-url-tracker
MIT License
17 stars 12 forks source link

You should not be able to edit the redirect source condition from a recommendation #186

Closed D-Inventor closed 2 months ago

D-Inventor commented 3 months ago

Is your feature request related to a problem? Please describe. When you create a redirect from a recommendation, you can edit the source condition, which makes no sense. It will make the recommendation disappear, but it will come right back, because it isn't actually solved.

Describe the solution you'd like The source condition option should be greyed out so that you cannot edit it, when you open the redirect edit panel from a recommendation.

Ideally, we should be able to control which options we can edit and which ones are greyed out from the code that opens the panel for full control. Ideally, the option to make properties fixed should not be dependent on the presence of a recommendation in the modal.

Describe alternatives you've considered We could also remove fixed options from the UI so that you can't see them. However, the panel as a whole is familiar and I think removing the options might make this interaction more confusing. On top of that, it adds some extra context about what you're doing.

Additional context Here is the code that creates the redirect options model. Here is an example call that opens the modal.