search

Infocatcher / Custom_Buttons

Buttons for Custom Buttons extension for Firefox (and other Gecko-based applications)
38 stars 11 forks source link

[Attributes_Inspector] The container box sometimes not displayed correctly #25

Closed sdavidg closed 9 years ago

sdavidg commented 10 years ago

Attributes_Inspector version 0.6.3pre2 - 2013-11-11 FF 31.0a1 (2014-03-31) / FF 29_0b3

sin ttulo3 sin ttulo2

Infocatcher commented 10 years ago

Oh, I see. Looks like something was "optimized" in Firefox 29+. :( Also all works fine for me with Windows 7 + Aero theme, but broken, if used classic theme.

I added some workarounds: still buggy reflects changes, but the data is at least visible.

sdavidg commented 10 years ago

Great! Thanks for the quick fix

Infocatcher commented 10 years ago

I had to disable this workaround by default due to performance problems on latest Firefox 33.0a1. Now should be changed manually:

-var _forceRepaintTooltip = false;
+var _forceRepaintTooltip = true;

Also old inIFlasher.repaintElement() doesn't work anymore and will be removed in Firefox 33 (32?): https://bugzilla.mozilla.org/show_bug.cgi?id=1018324 So, I updated workaround: a bit more buggy now, but still better than nothing.

Infocatcher commented 10 years ago

Oh, yes (from https://bugzilla.mozilla.org/show_bug.cgi?id=1018324), removed: https://hg.mozilla.org/mozilla-central/rev/4140ef233349#l2.108 temporarily restored: https://hg.mozilla.org/mozilla-central/rev/199108b7f25d#l2.108 So, now inIFlasher.repaintElement() just does nothing.

Infocatcher commented 10 years ago

Our workaround doesn't work in Thunderbird 31.2.0, see http://custombuttons.sourceforge.net/forum/viewtopic.php?p=9807#p9807

Infocatcher commented 9 years ago

Looks fixed now. @sdavidg, thanks again.

sdavidg commented 9 years ago

Thanks to you for this wonderful tool