search

Infocatcher / Custom_Buttons

Buttons for Custom Buttons extension for Firefox (and other Gecko-based applications)
38 stars 11 forks source link

Check for Addons Updates bug #39

Open seamoonz opened 9 years ago

seamoonz commented 9 years ago

Starting from FF 41 sometimes button checking updates forever (circle icon rolls and never stops) I'm using version 0.1.5 - 2014-10-13. I reverted it to version 40 and never experienced such problem. So it can't be related a conflict with other add-ons. Please restart FF before take another test.

Infocatcher commented 9 years ago

Strange, I can't reproduce. What happens for you on about:addons page + "Check for Updates" from menu? Should appears "Updating add-ons" and then "View Available Updates" or "No updates found" (button depends on that messages).

seamoonz commented 9 years ago

To reproduce open about:addons as a tab, select another tab, restart FF (don't switch about:addons tab), press update you should see forever loop. The only way to abort the loop is close about:addons tab.

seamoonz commented 9 years ago

Okay I have found the exact reason: To reproduce open about:addons as a tab, unpin it, select another tab, restart FF (don't switch about:addons tab), press update you should see forever loop.

1 minute video to show the problem: http://www25.zippyshare.com/v/i6F3qHVX/file.html

Infocatcher commented 9 years ago

Now I see, thanks. Weird things happens for not yet loaded tab... I've changed code to physically select pending tab (and then select original one) to correctly restore it, but this may looks strange, if there is many tabs.

There is latest version: https://github.com/Infocatcher/Custom_Buttons/blob/master/Check_for_Addons_Updates/checkForAddonsUpdates.js => Raw

seamoonz commented 9 years ago

Thanks lot for the update.