search

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

Australis OS X tab-bar issue #132

Closed dmedvinsky closed 10 years ago

dmedvinsky commented 10 years ago

On Nightly with new Australis interface, tab-bar normally looks like this:

screen shot 2014-02-01 at 19 35 54

When I create a new private tab, it still looks fine:

screen shot 2014-02-01 at 19 36 06

But when I switch back to normal tab, tab-bar sort of detaches from title-bar and moves down:

screen shot 2014-02-01 at 19 36 20

I've no idea why this happens and whether this is Private Tab's issue or Australis', but it would be great if you could take a look.

Infocatcher commented 10 years ago

This should be caused by fix for #44.

In Firefox 28.0a2 (and also in Firefox 29.0a1 from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-holly/), chrome://browser/content/browser.js:

let gPrivateBrowsingUI = {
  init: function PBUI_init() {
    // Do nothing for normal windows
    if (!PrivateBrowsingUtils.isWindowPrivate(window)) {
      return;
    }

    // Disable the Clear Recent History... menu item when in PB mode
    // temporary fix until bug 463607 is fixed
    document.getElementById("Tools:Sanitize").setAttribute("disabled", "true");

    if (window.location.href == getBrowserURL()) {
//@line 6911 "/builds/slave/m-aurora-osx64-ntly-0000000000/build/browser/base/content/browser.js"
      if (!PrivateBrowsingUtils.permanentPrivateBrowsing) {
        document.documentElement.setAttribute("drawintitlebar", true);
      }
//@line 6915 "/builds/slave/m-aurora-osx64-ntly-0000000000/build/browser/base/content/browser.js"

      // Adjust the window's title
      let docElement = document.documentElement;
      if (!PrivateBrowsingUtils.permanentPrivateBrowsing) {
        docElement.setAttribute("title",
          docElement.getAttribute("title_privatebrowsing"));
        docElement.setAttribute("titlemodifier",
          docElement.getAttribute("titlemodifier_privatebrowsing"));
      }

In Firefox 29.0a1:

let gPrivateBrowsingUI = {
  init: function PBUI_init() {
    // Do nothing for normal windows
    if (!PrivateBrowsingUtils.isWindowPrivate(window)) {
      return;
    }

    // Disable the Clear Recent History... menu item when in PB mode
    // temporary fix until bug 463607 is fixed
    document.getElementById("Tools:Sanitize").setAttribute("disabled", "true");

    if (window.location.href == getBrowserURL()) {
      // Adjust the window's title
      let docElement = document.documentElement;
      if (!PrivateBrowsingUtils.permanentPrivateBrowsing) {
        docElement.setAttribute("title",
          docElement.getAttribute("title_privatebrowsing"));
        docElement.setAttribute("titlemodifier",
          docElement.getAttribute("titlemodifier_privatebrowsing"));
      }

But I don't have Mac OS X and can't test this.

Infocatcher commented 10 years ago

Test version: private_tab-0.1.7pre4-fx-sm.xpi (source).

dmedvinsky commented 10 years ago

Test version works for me on OS X in both 28.0a2 (2014-02-01) without Australis and 29.0a1 (2014-02-01) with Australis. Can test on Linux only tomorrow, if required, but there were no problems before.

Thanks!

dmedvinsky commented 10 years ago

Oh, I looked at the diff and figured Linux would not be affected by the change.

Infocatcher commented 10 years ago

Should be fixed and can be closed, I think.