Closed dmedvinsky closed 10 years ago
This should be caused by fix for #44.
In Firefox 28.0a2 (and also in Firefox 29.0a1 from ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-holly/), chrome://browser/content/browser.js:
let gPrivateBrowsingUI = {
init: function PBUI_init() {
// Do nothing for normal windows
if (!PrivateBrowsingUtils.isWindowPrivate(window)) {
return;
}
// Disable the Clear Recent History... menu item when in PB mode
// temporary fix until bug 463607 is fixed
document.getElementById("Tools:Sanitize").setAttribute("disabled", "true");
if (window.location.href == getBrowserURL()) {
//@line 6911 "/builds/slave/m-aurora-osx64-ntly-0000000000/build/browser/base/content/browser.js"
if (!PrivateBrowsingUtils.permanentPrivateBrowsing) {
document.documentElement.setAttribute("drawintitlebar", true);
}
//@line 6915 "/builds/slave/m-aurora-osx64-ntly-0000000000/build/browser/base/content/browser.js"
// Adjust the window's title
let docElement = document.documentElement;
if (!PrivateBrowsingUtils.permanentPrivateBrowsing) {
docElement.setAttribute("title",
docElement.getAttribute("title_privatebrowsing"));
docElement.setAttribute("titlemodifier",
docElement.getAttribute("titlemodifier_privatebrowsing"));
}
In Firefox 29.0a1:
let gPrivateBrowsingUI = {
init: function PBUI_init() {
// Do nothing for normal windows
if (!PrivateBrowsingUtils.isWindowPrivate(window)) {
return;
}
// Disable the Clear Recent History... menu item when in PB mode
// temporary fix until bug 463607 is fixed
document.getElementById("Tools:Sanitize").setAttribute("disabled", "true");
if (window.location.href == getBrowserURL()) {
// Adjust the window's title
let docElement = document.documentElement;
if (!PrivateBrowsingUtils.permanentPrivateBrowsing) {
docElement.setAttribute("title",
docElement.getAttribute("title_privatebrowsing"));
docElement.setAttribute("titlemodifier",
docElement.getAttribute("titlemodifier_privatebrowsing"));
}
But I don't have Mac OS X and can't test this.
Test version: private_tab-0.1.7pre4-fx-sm.xpi (source).
Test version works for me on OS X in both 28.0a2 (2014-02-01) without Australis and 29.0a1 (2014-02-01) with Australis. Can test on Linux only tomorrow, if required, but there were no problems before.
Thanks!
Oh, I looked at the diff and figured Linux would not be affected by the change.
Should be fixed and can be closed, I think.
On Nightly with new Australis interface, tab-bar normally looks like this:
When I create a new private tab, it still looks fine:
But when I switch back to normal tab, tab-bar sort of detaches from title-bar and moves down:
I've no idea why this happens and whether this is Private Tab's issue or Australis', but it would be great if you could take a look.