search

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

"New Private Tab" resets to end of tab bar on restart in Firefox 29.0a2 (Aurora) #134

Closed ssokolow closed 10 years ago

ssokolow commented 10 years ago

I just updated to Firefox 29 with its new Australis theme and, while everything more or less works, restarting the browser forces the New Private Tab button back to the end of the tab bar, beyond things like the Tab Groups button.

Infocatcher commented 10 years ago

Strange, works fine for me. Also with Australis should be used new CustomizableUI API: https://github.com/Infocatcher/Private_Tab/blob/0.1.7/bootstrap.js#L2126 So, probably, this is API bug... And what you have in browser.uiCustomization.state preference?

Anyway, please set extensions.privateTab.debug = true on about:config page and check Browser Console (Ctrl+Shift+J), if all works correct, you should see messages like following:

[Private Tab] 51:45:030 Insert toolbar button #privateTab-toolbar-openNewPrivateTab into palette [Private Tab] 51:45:030 Toolbar button: use CustomizableUI.ensureWidgetPlacedInWindow()

And where you move "New Private Tab" button? Probably some bugs with special button after last tab.

ssokolow commented 10 years ago

Here's what I get when I drag from the right-most position to just beside the + button with debug enabled:

[Private Tab] 05:36:372 drop: from not private tab [Private Tab] 05:36:372 Will use target private state (from window) [Private Tab] 05:36:372 Will use source or target private state: false || false [Private Tab] 05:36:372 waitForTab() [Private Tab] 05:36:389 waitForTab(): nothing [Private Tab] 05:47:001 Move "New Private Tab" button after "New Tab" button [Private Tab] 05:47:068 setupListAllTabs(true)

Infocatcher commented 10 years ago

with debug enabled

This looks correct. Also in browser.uiCustomization.state preference should be something like

{
    "placements": {
        ...
        "TabsToolbar": ["tabbrowser-tabs", "new-tab-button", "privateTab-toolbar-openNewPrivateTab", "tabview-button", "alltabs-button", "tabs-closebutton"],

(you can use http://jsbeautifier.org/ to decode JSON string)

To ensure, that I understand correct. You have

Tabs | New Tab | New Private Tab | Tab Groups

before restart and

Tabs | New Tab | Tab Groups | New Private Tab

after?

And do you see Toolbar button: use CustomizableUI.ensureWidgetPlacedInWindow() debug message after restart?

Can you reproduce this bug on new empty Firefox profile? This may be conflict with some other extension...

ssokolow commented 10 years ago

Sorry I didn't have time to look into it further (life's been very busy), but the problem seems to have resolved itself, so I guess that's fine too.