search

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

Custom Color Underline #160

Closed joesimmons closed 9 years ago

joesimmons commented 9 years ago

Can you make the dashed underline color changeable? Fairly simple, maybe just give a hex option and a link to a color picker site where they can choose a color.

And as if it needed a reason, my personal reason is because I have Colorful Tabs and it's hard to see green on green or a similar color.

Infocatcher commented 9 years ago

Oh, it's already possible, but only using userChrome.css or Stylish extension: https://github.com/Infocatcher/Private_Tab#styles

joesimmons commented 9 years ago

I know, and I already did that. But why not just add an option into the add-on itself?

BTW, I think text-decoration-style wavy is much better than dashed. It's more easily seen. I made it black in that style just because I use Colorful Tabs, as stated above, and black is always seen for me.

Infocatcher commented 9 years ago

Yes, this is something that "nice to have", but there is many combinations with third-party extensions and possible styles. It's easy to implement options around underlining (oh, not so easy, built-in controls doesn't allow custom things like system colors), but since this is already possible using styles, this feature has low priority, sorry.

joesimmons commented 9 years ago

I understand.

ps: maybe you'll switch to "wavy" in the future? What are your thought on it versus "dashed"?

Infocatcher commented 9 years ago

What are your thought on it versus "dashed"?

Oh, just because I associate dashed line with something temporary.