search

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

RDM kill browser in private tab #255

Closed dehghani-mehdi closed 7 years ago

dehghani-mehdi commented 7 years ago

Hello,

I'm using FF v52.0.2, also latest version of Private_Tab addon. sometimes when a page is open in Private tab (not private window), if I try to switch to mobile view (RDM I mean), Firefox doesn't response to anything & I have to close the main process. I tired in Private window multiple times & this didn't happen.

anewuser commented 7 years ago

You need to be more specific when you report bugs. What page caused the crash? I just tested the Responsive Design Mode both on example.org and Github in private tabs, and it worked as expected.

dehghani-mehdi commented 7 years ago

Excuse me @anewuser , are you a member/contributor of this project? you posted comment to almost all of issues. interesting.

As I mentioned in my post, I said sometimes.

Infocatcher commented 7 years ago

are you a member/contributor of this project? you posted comment to almost all of issues. interesting.

Any user may help and any help is appreciated. :)

Responsive Design Mode works fine for me, but only with disabled multi-process mode. And completely broken in multi-process mode.

dehghani-mehdi commented 7 years ago

@Infocatcher I enabled e10s, I'm not sure but I think if page has lot of JS code, RDM will be broken in Private Tab, but not always. Notice that there is no issue with RDM for me in regular tabs

dehghani-mehdi commented 7 years ago

This issue still exists in FF 53, I removed your useful add-on today, also I think your add-on is not compatible enough with FF. (FF show strange behavior some times if one of tabs use PrivateTab)

Infocatcher commented 7 years ago

also I think your add-on is not compatible enough with FF. (FF show strange behavior some times if one of tabs use PrivateTab)

More details, please.

And from https://addons.mozilla.org/addon/private-tab/reviews/866216/

Almost unusable with FF +52
It was great add-on, I wrote a review before, it was my #1 add-on, but not anymore, RDM (Responsive Design Mode) is not compatible with PrivateTab (there an issue about that in bugzilla). also seems like the developer doesn't support the add-on, (there is 58 open issues on Github)

There is no way to fix anything, if Firefox developers takes backward incompatible changes in each release without working feedback. For example, see https://github.com/Infocatcher/Private_Tab/issues/237#issuecomment-261311012

Also it's not possible to handle bugs like a UI hangs from extension side (if extension do nothing during that hang). Sad, but true.

About open issues: feel free to fix something or find someone to fix that for you, this is free and open source project.
Also I'm still unable to reproduce your issue with disabled e10s mode.
dehghani-mehdi commented 7 years ago

Thanks for the response, you right, Firefox lost the way, it's hard to keep up to date the add-on with Firefox changes. (and yes your code is open source, free & available for change/edit)

BUT I'm developer too man, I have not any open source project like you, but I think if you can not (not about your skills or ability) for any reason to fix the problems, at least warn the users about possibility issues about using your code. you did this for users, it's great, but respect them & their time.

Anyway I believe Mozilla is not in right way about Firefox (it's not good for you as add-on developer and people like me as FF users), today I removed your add-on, maybe tomorrow I decided to switch to Chrome.

I reported this issue because I like to let you know about existing problem, your idea and add-on is most useful idea about add-on (in my opinion). I'm not fan of add-ons, but PrivateTab is great and useful, and I wrote that review to let other people know about existing issue about your add-on to help them as well.

Thanks again ;)