Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

Incompatible with Tile Tabs 10.0: tabs opened from private tabs doesn't becomes private #83

Closed Infocatcher closed 11 years ago

Infocatcher commented 11 years ago

Tile Tabs: https://addons.mozilla.org/firefox/addon/tile-tabs/ (all works fine with Tile Tabs 9.2)

STR:

  1. Open any page in private tab.
  2. Middle-click on any link.
  3. New tab will be opened with "New Tab" label instead of "Connecting…"/"Loading…" (visible only until page title not yet received) and will be not private.

And Private Tab check label of new tabs to detect empty tabs, based on chrome://browser/content/tabbrowser.xml

      <method name="addTab">
        ...
            var uriIsAboutBlank = !aURI || aURI == "about:blank";

            if (!aURI || isBlankPageURL(aURI))
              t.setAttribute("label", this.mStringBundle.getString("tabs.emptyTabTitle"));
            else
              t.setAttribute("label", aURI);

Also Private Tab works correct without following statements (but tab label still wrong): chrome\content\tiletabs-browser.js


    onTabOpen: function(event)
    {
        ...
        if (gBrowser.selectedTab.hasAttribute("tiletabs-assigned") && tileTabs.viewTiled)
        {
            tileTabs.hideAllPanels();
            tileTabs.drawActiveLayout();
            tileTabs.highlightPanel();
        }
        else
        {
            tileTabs.hideAllPanels();
            tileTabs.drawSelectedPanel();
        }
        tileTabs.styleTiledTabs();
    },

Anyway, wrong tab label is a Tile Tabs bug and (probably) no possible workaround from Private Tab side.

notpeelz commented 11 years ago

I second this, I have been experiencing the same issue since I have installed Tile Tabs.

I run Firefox rev 22, Tile Tabs 10.0, Private Tabs 0.1.3.

Infocatcher commented 11 years ago

I emailed to author using "Support E-mail" from AMO page, but he hasn't yet answered.

Infocatcher commented 11 years ago

Seems like Private Tab works correctly with this workaround: f5524fc35499329058b41568954d1297d93123d3 Test version: private_tab-0.1.4pre4-fx-sm.xpi (source).

Infocatcher commented 11 years ago

(Tile Tabs still buggy with tab labels, but Private Tab handles tabs earlier.)

notpeelz commented 11 years ago

This seems to have fixed the issue (for now at least). Thanks.

Looking forward for the full patch.

Infocatcher commented 11 years ago

I emailed to author using "Support E-mail" from AMO page, but he hasn't yet answered.

I've got answer from author with attached Tile Tabs 10.1 Beta 1. It seems all works fine for me (now all OK with tab labels) with Private Tab 0.1.3 and with current development version.

notpeelz commented 11 years ago

All good. Thank you :+1:

Infocatcher commented 11 years ago

Tile Tabs 10.1: https://addons.mozilla.org/addon/tile-tabs/versions/10.1 (not yet reviewed) and I will release Private Tab 0.1.4 with fixes for Tile Tabs 10.0 soon.