search

Infocatcher / Private_Tab

Adds private tabs, restartless extension for Firefox (20.0+) and SeaMonkey (2.17+)
https://addons.mozilla.org/addon/private-tab/
Other
86 stars 20 forks source link

Compatibility problem with TabMixPlus multi-row feature #95

Closed ntv1000 closed 11 years ago

ntv1000 commented 11 years ago

When using the multi-row feature of TabMixPlus (latest (dev) build today) with 3 or more rows Private Tab enabled, an empty tab-row appears like in the attatched image. (Firefox 23.0.1, tested with clean profile) privatetabproblem

Infocatcher commented 11 years ago

Can't reproduce. May be OS-specific... I think, this may be caused by "New Private Tab" button after last tab (is this bug exists in Private Tab 0.1.3?). Please try following style for userChrome.css:

#privateTab-afterTabs-openNewPrivateTab {
    display: none !important;
}

– may be I can just use this to hide it instead of visibility: collapse.

And please report this also to Tab Mix Plus developers.

ntv1000 commented 11 years ago

Both solutions you suggested fix the problem. Thank you for your time! Reported it to the TabMixPlus developers, too.

Infocatcher commented 11 years ago

This style isn't complete solution, just a test, I used more complex styles: https://github.com/Infocatcher/Private_Tab/blob/0.1.5/bootstrap.js#L2809 (and I see another issue with Tab Mix Plus: https://github.com/Infocatcher/Private_Tab/issues/96) So I can modify my styles, but the same may happens with Tab Mix Plus and any other extension with collapsed things on tabs level. If this can be fixed from TMP side, it's better to do it there.

Reported it to the TabMixPlus developers, too.

Thanks. The link should be also here: https://bitbucket.org/onemen/tabmixplus/issue/11/compatibility-problem-of-multi-row-feature

onemen commented 11 years ago

Look like both #95 and #96 caused by the same problem. privateTab-afterTabs-openNewPrivateTab isn't visible after tabs probably since tabmixScrollBox come between the button and new-tab-button on tabbrowser-tabs.

Did you fix issue #96, how can i download and test the extensions with the new patch ?

In multi-row i have special css rules to make sure that .tabbrowser-arrowscrollbox > .tabs-newtab-button is not visible, event if tabs are not overflow, if the button don't have space to be on the same row with the last tab.

Now, when there are two button this is event more complicating

It is simpler to apply the rules that hide the button on overflow also when there are more then one row

Infocatcher commented 11 years ago

Did you fix issue #96, how can i download and test the extensions with the new patch ?

Sorry, only source code available... https://github.com/Infocatcher/Private_Tab/commit/4ca9d51e7ae96c49bd4ab54c9a07c9bdadada01c => Browse code => Download ZIP (Or https://github.com/Infocatcher/Private_Tab => commits => Browse code for some commit) But unfortunately downloaded code should be repacked to place install.rdf in ZIP archive's root.

Anyway, I uploaded "ready" xpi: https://github.com/Infocatcher/Private_Tab/issues/96#issuecomment-23629840

onemen commented 11 years ago

with the changes i mention in #96 comment 5 and the changes i'm made to Tabmix this issue can be closed

try the test version https://bitbucket.org/onemen/tabmixplus/downloads/tab_mix_plus-0.4.1.1pre.130821b-privateTabs-compatibility-test.xpi

https://bitbucket.org/onemen/tabmixplus/commits/05dc5e62126d4824f9ffa72cd3edd3c02b0b004a https://bitbucket.org/onemen/tabmixplus/commits/6611c2ab1e932ed463571ade9bfe1e20831b9af9 https://bitbucket.org/onemen/tabmixplus/commits/3f15c8bf5087a6adb4ef8733805128715c69911b

ntv1000 commented 11 years ago

try the test version https://bitbucket.org/onemen/tabmixplus/downloads/tab_mix_plus-0.4.1.1pre.130821b-privateTabs-compatibility-test.xpi

Tested this version and can verify that it solves the compatibility problem. I can only say thank you both, since I like the combination of these two extensions!