search

Infocatcher / Private_Tab_WE

WebExtensions port of Private Tab extension for Firefox
42 stars 0 forks source link

Not compatible with Firefox Quantum #1

Open vic4key opened 6 years ago

vic4key commented 6 years ago

Hi @Infocatcher,

This add-on is now not compatible with Firefox Quantum. Could you please spend time to update it as soon as possible? I very like your add-on, it's very useful. Thanks you so much.

Best Regards, Vic P.

ghost commented 6 years ago

Look at the README, there are 2 blocking bugs on Firefox's side. Not much the author can do unless they contribute directly to firefox itself.

vic4key commented 6 years ago

Oops. Hope to be able to find a good solution for this. Thanks.

anewuser commented 6 years ago

Check this out: https://github.com/stoically/firefox-add-on-temporary-containers

Infocatcher commented 6 years ago

Check this out: https://github.com/stoically/firefox-add-on-temporary-containers

Hmm... as I see, still used something custom to remove history entries. Store each visited URL: https://github.com/stoically/firefox-add-on-temporary-containers/blob/ea04a06af2d40d04e4f0c6960e1e6761cedc6f05/src/background/request.js#L33-L44 And then remove them: https://github.com/stoically/firefox-add-on-temporary-containers/blob/ea04a06af2d40d04e4f0c6960e1e6761cedc6f05/src/background/container.js#L227-L237 Better, than nothing, but also will be removed regular history, if will be opened the same URL in non-private and "private" mode/container. :(

anewuser commented 6 years ago

That's because of https://bugzilla.mozilla.org/show_bug.cgi?id=1283320.

Apart from than that, he's added many combinations of options and has plans for adding more. Maybe you should collaborate with him with your ideas and experience to make it as efficient as possible instead of having to reinvent the wheel?

vic4key commented 6 years ago

Seem it cleans sth. Not able to use normal mode and private together.

anewuser commented 6 years ago

@vic4key Disable the automatic mode in the settings.

vic4key commented 6 years ago

Great. Thank you so much, bro.

stoically commented 6 years ago

@Infocatcher

Better, than nothing, but also will be removed regular history, if will be opened the same URL in non-private and "private" mode/container. :(

Yeah, it's also explicitly mentioned as a big red warning in the opt-in advanced preferences that exactly that happens until history support for containers is added.

Also, if you're interested, I'd be absolutely open to collaborate. Just let me know if I can be of any help if you consider starting the WebExtension Development.

@vic4key Sorry for the hassle, I'll try to make the on-boarding easier.

Thanks @anewuser for helping out!