search

Infocatcher / Right_Links

Open links in new tabs using right-click or "long" left-click, extension for Firefox and SeaMonkey
https://addons.mozilla.org/addon/right-links/
Other
22 stars 3 forks source link

Real links, that looks like dummy, may be opened in current tab #1

Closed Infocatcher closed 11 years ago

Infocatcher commented 11 years ago

Reported here: https://addons.mozilla.org/addon/right-links/reviews/471454/ Testcase: https://picasaweb.google.com/102637044608602136429/SchwarzwaldBlackForestOrBlueMountains?noredirect=1 (thumbnails)

URLs looks like <a href="#123456789"> and linked anchors doesn't exists on the page.

So we can emulate Ctrl+left-click (instead of just left-click) on such links or add target="_blank" attribute. This will be buggy for

<a href="#preview" onclick="window.open(location.href);">...</a>

But this code is wrong and should be

<a href="#preview" onclick="window.open(location.href); return false;">...</a>
s0lution commented 11 years ago

Thanks for the fix. But there's a problem now with closing tabs (at Picasa) opened with right click. I have to doubleclick on the X at the tab to close it. Or i have to click once into the content of the tab before i can click the X. Seems to be some "autofocus" problem?

Infocatcher commented 11 years ago

I have to doubleclick on the X at the tab to close it. Or i have to click once into the content of the tab before i can click the X.

Oh, I see. But this is different bug (and this bug exists in previous version), so I created another ticket: #2.

Infocatcher commented 11 years ago

Oops, I accidentally deleted my post with link to test version, here is it's contents:

Test version: right_links-0.3.8.2pre-fx-sm.xpi (source).
Should work on Picasa pages, but may break something else...

Also now available new test version with workaround for not clickable tabs: https://github.com/Infocatcher/Right_Links/issues/2#issuecomment-21049935.

Infocatcher commented 11 years ago

Seems to works fine for me, so I closed the issue.