search

Infocatcher / Right_Links

Open links in new tabs using right-click or "long" left-click, extension for Firefox and SeaMonkey
https://addons.mozilla.org/addon/right-links/
Other
22 stars 3 forks source link

Add support for Feed Sidebar add-on #12

Closed Keith94 closed 10 years ago

Keith94 commented 10 years ago

I would like to request adding support for Feed Sidebar, so feed items in the sidebar can be opened with right click. Thanks.

Infocatcher commented 10 years ago

Implemented. Test version: right_links-0.3.8.4pre2-fx-sm.xpi (source source).

But there is no direct links with extensions.feedbar.showFullPreview = true and in offline mode (and in this case will be emulated middle-click), see resource://feedbar-modules/treeview.js https://addons.mozilla.org/files/browse/252130/file/modules/treeview.js#L1305

    onTreeClick : function (event, url) {
        ...
        var win = FEEDBAR.window;
        var online = (win && win.navigator.onLine);

        if (!url && (FEEDBAR.prefs.getBoolPref("showFullPreview") || !online)) {
            FEEDBAR.handleOfflineTreeClick(event, url);
            return;
        }

And FEEDBAR.handleOfflineTreeClick() uses FEEDBAR.loadFullPreview() with many special codes: https://addons.mozilla.org/files/browse/252130/file/modules/treeview.js#L1812

Keith94 commented 10 years ago

So with that showFullPreview pref set to false, new feed items aren't marked as read when they're opened using right click or long left click.

Infocatcher commented 10 years ago

new feed items aren't marked as read when they're opened using right click or long left click.

I forgot about this... I open links manually to use Right Links options, so Feed Sidebar just doesn't know about that. Should be corrected now, but this is depends on Feed Sidebar internals... I re-uploaded test version (link still the same).

Keith94 commented 10 years ago

Indeed it's fixed now, thanks again.