Closed Keith94 closed 10 years ago
Implemented.
Test version: right_links-0.3.8.4pre2-fx-sm.xpi (source source).
But there is no direct links with extensions.feedbar.showFullPreview = true and in offline mode (and in this case will be emulated middle-click), see resource://feedbar-modules/treeview.js https://addons.mozilla.org/files/browse/252130/file/modules/treeview.js#L1305
onTreeClick : function (event, url) {
...
var win = FEEDBAR.window;
var online = (win && win.navigator.onLine);
if (!url && (FEEDBAR.prefs.getBoolPref("showFullPreview") || !online)) {
FEEDBAR.handleOfflineTreeClick(event, url);
return;
}
And FEEDBAR.handleOfflineTreeClick() uses FEEDBAR.loadFullPreview() with many special codes: https://addons.mozilla.org/files/browse/252130/file/modules/treeview.js#L1812
So with that showFullPreview pref set to false, new feed items aren't marked as read when they're opened using right click or long left click.
new feed items aren't marked as read when they're opened using right click or long left click.
I forgot about this... I open links manually to use Right Links options, so Feed Sidebar just doesn't know about that. Should be corrected now, but this is depends on Feed Sidebar internals... I re-uploaded test version (link still the same).
Indeed it's fixed now, thanks again.
I would like to request adding support for Feed Sidebar, so feed items in the sidebar can be opened with right click. Thanks.