search

Infocatcher / Right_Links

Open links in new tabs using right-click or "long" left-click, extension for Firefox and SeaMonkey
https://addons.mozilla.org/addon/right-links/
Other
22 stars 3 forks source link

Long left-click opens not actual URI, if URI was changed after mousedown #9

Closed LouieChuckyMerry closed 10 years ago

LouieChuckyMerry commented 10 years ago

Infocatcher: Thank you very much for Right Links, it's a Five-Star add-on and I really appreciate it :) . I've noticed that when I use Long Left-Click to open a link in a Google search window that the link doesn't change from blue to purple, however, if I open it a second time using Long Left-Click or open it using Right-Click/Open Link in New Tab that it does change color. Please, is there a way to make it so that opening a link one time using Long Left-Click changes the link from blue to purple? Thanks for your time.

Infocatcher commented 10 years ago

I've noticed that when I use Long Left-Click to open a link in a Google search window that the link doesn't change from blue to purple, however, if I open it a second time using Long Left-Click or open it using Right-Click/Open Link in New Tab that it does change color.

I see. This is because Google change link on mousedown event to something like http://www.google.com/url?.... And long left-click also starts on mousedown, but before scripts from page, so will be remembered (and opened after delay) initial direct link.

This can be (and should be, I think) fixed from Right Links side, but you also can use Google/Yandex search link fix extension or Remove fake links script for Greasemonkey to remove such tracking links.

Infocatcher commented 10 years ago

Test version: right_links-0.3.8.4pre-fx-sm.xpi (source).

LouieChuckyMerry commented 10 years ago

Infocatcher: thanks for your reply. The user script didn't change anything but the Google/Yandex search link fix did the job. Thanks again.

Infocatcher commented 10 years ago

The user script didn't change anything

Strange, works fine for me.

but the Google/Yandex search link fix did the job.

Great. But can you please also check updated Right Links from https://github.com/Infocatcher/Right_Links/issues/9#issuecomment-34974434 without any scripts and extensions?

LouieChuckyMerry commented 10 years ago

Perhaps I applied the user script incorrectly (although Greasemonkey seemed to think everything was OK). I just checked the updated Right Links above and that works great on a couple of test Google searches. Thank you very much :) .

Edit: Seems I misunderstood the term "Close".

LouieChuckyMerry commented 10 years ago

Hi Infocatcher. I just received email notification of your closing of this thread (but nothing regarding your "fixed?" post or I would've replied earlier). I tested some links with your newest version of Right Links, and with the Google/Yandex search link disabled, and all was well. Thanks again for your help :) .

Infocatcher commented 10 years ago

Now there is official (but not yet reviewed) release: https://addons.mozilla.org/addon/right-links/versions/0.3.8.4