search

Infocatcher / Sidebars_List

Adds drop-down list to switch sidebars, restartless extension for Firefox
https://addons.mozilla.org/firefox/addon/sidebars-list/
Other
1 stars 1 forks source link

Sidebar Locks up #6

Open JeremyWW opened 10 years ago

JeremyWW commented 10 years ago

Hi,

I have an issue where the side bar will, after a while, lock up. So I have the sidebar open and I'm opening / using a number of tabs. I return to the sidebar to find that I can not close it or collapse it, the only option is to close Firefox.

Anyone else?

Thanks

Infocatcher commented 10 years ago

Do you use "Collapse sidebar (instead of close)" option? Also please open error console (Ctrl+Shift+J) before trying to close sidebar and copy/paste here any errors and warnings related to Sidebars List.

JeremyWW commented 10 years ago

Just happened. I’m using default options – image attached.

Log below:

09:18:39.996 TypeError: sidebarBroadcaster is null browser.js:13702

09:18:42.372 TypeError: sidebarBroadcaster is null browser.js:13702

09:18:44.429 TypeError: sidebarBroadcaster is null browser.js:13702

09:18:46.477 TypeError: sidebarBroadcaster is null browser.js:13702

09:18:48.389 TypeError: sidebarBroadcaster is null browser.js:13702

09:18:50.141 TypeError: sidebarBroadcaster is null browser.js:13702

09:18:51.757 TypeError: sidebarBroadcaster is null browser.js:13702

Thanks for responding. It’s a very useful extension – it would be a shame not to use it.

From: Infocatcher [mailto:notifications@github.com] Sent: 29 January 2014 08:06 To: Infocatcher/Sidebars_List Cc: JeremyWW Subject: Re: [Sidebars_List] Sidebar Locks up (#6)

Do you use "Collapse sidebar (instead of close)" option? Also please open error console (Ctrl+Shift+J) before trying to close sidebar and copy/paste here any errors and warnings related to Sidebars List.

— Reply to this email directly or view it on GitHub https://github.com/Infocatcher/Sidebars_List/issues/6#issuecomment-33563767 . https://github.com/notifications/beacon/544340__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjUxNTU3NCwiZGF0YSI6eyJpZCI6MjQ0MTE0MTd9fQ==--df67e8aaaa231dc31f745e5a230e194e5e4e1923.gif

Infocatcher commented 10 years ago

Looks like "Reply to this email directly" doesn't support attachments.

I think, Sidebars List itself shouldn't cause this error (at least directly). Probably some another extension wrongly modifies sidebarcommand attribute: chrome://browser/content/browser.js

function toggleSidebar(commandID, forceOpen) {

  var sidebarBox = document.getElementById("sidebar-box");
  if (!commandID)
    commandID = sidebarBox.getAttribute("sidebarcommand");

  var sidebarBroadcaster = document.getElementById(commandID);
  ...

  if (sidebarBroadcaster.getAttribute("checked") == "true") { // Error happens here

Or you use some non-standard sidebar (from some extension)...

Infocatcher commented 10 years ago

Anyway, I implemented possible workaround, test version: sidebars_list-0.1.2pre8-fx.xpi (source)

(But it's better to understand the real reason, of course...)

JeremyWW commented 10 years ago

Only extensions I have (on a clean FF profile) are:

Adblock Plus (no subscriptions, just a few ad blocking filters of my own for a couple of sites)

Password Maker

S3 Google Translate

I have no other sidebar extensions and no other extensions that have been installed in this profile. The only other browser is IE which I don't use.

That's it...

Sent from my phone

On January 29, 2014 1:04:01 PM Infocatcher notifications@github.com wrote:

Looks like "Reply to this email directly" doesn't support attachments.

I think, Sidebars List itself shouldn't cause this error (at least directly). Probably some another extension wrongly modifies sidebarcommand attribute: chrome://browser/content/browser.js

function toggleSidebar(commandID, forceOpen) {

  var sidebarBox = document.getElementById("sidebar-box");
  if (!commandID)
    commandID = sidebarBox.getAttribute("sidebarcommand");

  var sidebarBroadcaster = document.getElementById(commandID);
  ...

  if (sidebarBroadcaster.getAttribute("checked") == "true") { // Error 
  happens here

Or you use some non-standard sidebar (from some extension)...

Reply to this email directly or view it on GitHub: https://github.com/Infocatcher/Sidebars_List/issues/6#issuecomment-33582389

JeremyWW commented 10 years ago

OK, I’ve installed this so I’ll let you know how it goes – I’ll do my best to break it!

Thanks.

From: Infocatcher [mailto:notifications@github.com] Sent: 29 January 2014 13:05 To: Infocatcher/Sidebars_List Cc: JeremyWW Subject: Re: [Sidebars_List] Sidebar Locks up (#6)

Anyway, I implemented possible workaround, test version: sidebars_list-0.1.2pre8-fx.xpi http://infocatcher.ucoz.net/temp/sbl/sidebars_list-0.1.2pre8-fx.xpi (source https://github.com/Infocatcher/Sidebars_List/tree/70a14ee4154cbf24af7ba828a8035b4d0dd17220 )

(But it's better to understand the real reason, of course...)

— Reply to this email directly or view it on GitHub https://github.com/Infocatcher/Sidebars_List/issues/6#issuecomment-33582454 . https://github.com/notifications/beacon/544340__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjUzMzQ5NywiZGF0YSI6eyJpZCI6MjQ0MTE0MTd9fQ==--580eac68bae3777a29ce8f072751193089ebb049.gif

Infocatcher commented 10 years ago

Also if this bug happens again (with test version), please set extensions.sidebarslist.debug = true on about:config page, open error console (Ctrl+Shift+J) and try to close sidebar again.

JeremyWW commented 10 years ago

At the moment I’m just trying the released version of Sidebars List without the ‘S3 Google Translator’ installed. I have a funny feeling that it might be interfering in some way. Perhaps you should take a look…

From: Infocatcher [mailto:notifications@github.com] Sent: 29 January 2014 17:22 To: Infocatcher/Sidebars_List Cc: JeremyWW Subject: Re: [Sidebars_List] Sidebar Locks up (#6)

Also if this bug happens again (with test version), please set extensions.sidebarslist.debug = true on about:config page, open error console (Ctrl+Shift+J) and try to close sidebar again.

— Reply to this email directly or view it on GitHub https://github.com/Infocatcher/Sidebars_List/issues/6#issuecomment-33607202 . https://github.com/notifications/beacon/544340__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjU0ODkzOCwiZGF0YSI6eyJpZCI6MjQ0MTE0MTd9fQ==--bbb32bef0fd7b12a3616f499bce282f67002e521.gif

JeremyWW commented 10 years ago

OK, the release version locked up again. Note very precise but I had around 30+ tabs open, and started a download from TPB. When I returned to the sidebar it had locked up and couldn't be closed. I now have the test version installed again and no problems so far, including a test to mimic the situation above.

Yet another clean profile, with only Adblock and Password Maker installed. As before, Adblock uses NO subscriptions and just a handful of ad blocking filters.