search

Infomaniak / android-kDrive

https://play.google.com/store/apps/details?id=com.infomaniak.drive
GNU General Public License v3.0
89 stars 9 forks source link

Cannot configure photo backup to `save all` #1308

Open leocencetti opened 1 month ago

leocencetti commented 1 month ago

Description When configuring the photo backup to save all photos, the setting is not applied, and the option rolls back to from now on.

Steps to reproduce Steps to reproduce the behavior:

  1. Go to the photo backup settings
  2. Change the save mode to save all
  3. Click the save button
  4. Reopen the photo backup settings
  5. The save mode is now from now on

Expected behavior The saving mode should be applied properly. If not compatible with other settings, a warning should be shown.

Screenshots Before step 2 After step 4
Screenshot_20240516-193836_kDrive Screenshot_20240516-193848_kDrive

Smartphone (please complete the following information):

leocencetti commented 1 month ago

Looks like this may be a UI-only issue. The synchronization seems to be including all images after all.

JorisBodin commented 1 month ago

Hello,

This setting only allows you to choose the start date for selecting the photos to be synchronized. Once saved, the worker will scan all photos from this date onwards. So, strictly speaking, the parameter is not saved, only the date. We could stop displaying this option afterwards to avoid confusion. So just a problem of understanding

https://github.com/Infomaniak/android-kDrive/blob/6e3927b62c7599fb145c29a2ba5f8925335cd605/app/src/main/java/com/infomaniak/drive/ui/menu/settings/SyncSettingsActivity.kt#L352

leocencetti commented 1 month ago

Hey @JorisBodin, thanks for the info. It would be great if the selection could be reflected in the UI as well, to inform to the user that his configuration has been applied (thus avoiding the confusion).