Infomaniak / android-kDrive

https://play.google.com/store/apps/details?id=com.infomaniak.drive
GNU General Public License v3.0
96 stars 10 forks source link

Remove the gap between the bottom sheet and the bottom of the screen #1330

Closed NicolasBourdin88 closed 1 month ago

NicolasBourdin88 commented 1 month ago

The gap is the result of set 'isFitContent' to false on the bottom sheet behavior but unfortunately it's either the gap or the half state on the bottom sheet.

The only solution that i founded is to fill the gap with 'match_parent' so we have half_state and no gap.

tevincent commented 1 month ago

I want to test something. I'll let you know if I find something.

tevincent commented 1 month ago

What we had before:

https://github.com/Infomaniak/android-kDrive/assets/149579879/f0bf7d71-5b4f-4461-90d0-9955cc370e0d

The quickfix:

https://github.com/Infomaniak/android-kDrive/assets/149579879/af890bd5-206c-4847-b5f5-584fa17ac504

With a custom class to handle the BottomSheet behavior:

https://github.com/Infomaniak/android-kDrive/assets/149579879/627a4e70-b548-440c-906d-81f347a2e1a2

KevinBoulongne commented 1 month ago

This removes the native interaction behaviors that the bottom sheet naturally has makes it harder to use and less intuitive unfortunately

@LunarX What does it remove ? Your comment is very unclear.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud