Infomaniak / desktop-kDrive

:computer: Desktop Syncing Client for kDrive
GNU General Public License v3.0
29 stars 5 forks source link

KDESKTOP-930 Check for getRights method performance at startup and if… #155

Closed herve-er closed 5 months ago

herve-er commented 5 months ago

Summary

On Windows, we are experiencing significant slowdowns for some users due to the methods used to set/get rights via the Windows API on Windows Server. This issue stems from the API making network calls to the Active Directory manager with each request.

Details

Identified Issue

The slowdown is caused by the Windows API functions making network calls to the Active Directory manager.

Performance Measurements

Current Workaround

The current solution involves instructing clients to set an environment variable to bypass the recommended Windows API methods, instead using standard methods. However, the standard methods rely solely on the read-only flag, which often does not accurately reflect the actual rights applied to the file/folder. Despite this limitation, it remains the better option given the constraints.

Proposed Improvement

This pull request aims to eliminate the need for manual environment variable configuration. The application will automatically select the most appropriate method for rights management, improving overall performance and user experience.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud