Kdesktop 992 Add a modal to lock the app when the current version is forbidden.

[herve-er]

Description

This PR aims to provide a solution allowing us to make a version of the app unusable.

Technical Solution

The technical solution selected is to catch any error 406 response on any kDrive API request (update and login are not concerned). When such an error is fetched, it is propagated up to a point where it is added as an error (either in appserver or in executorworker). This error is then fetched on the client side, which is interpreted and leads to closing all the opened windows except for synthesispopover. Synthesispopover adopts a specific "locked App" design:

Depending on the update process (Windows, macOS, Linux) the button can show different messages:

• Update
• Download in progress
• Looking for updates
• Error

Tests

As their is currently no test for the updaters, this PR also come with some unit test. However, Due to the current implementation, all the updaters methods are not eligible to unit test and the coverage cannot be as high as desired.

A completely new implementation of the updater will come soon, with a new internal API road. This one must be done following a TDD approach.

---

Tasklist

• Handle Linux TaskBar

  • [x] Linux implementation
  • [x] Linux Test

• Display the link for the manual update

  • [x] All plateform

• Error page when no update available / failed to fetch last update

  • [x] All plateform (Waiting for UI/UX Validation)

• Implement a way to proposed a skipped version in case of locked app

  • [x] Windows
  • [x] Mac
  • [x] Linux (Not concerned)

• Test 406 error in mid sync:

  • [x] Windows
  • [x] Mac
  • [x] Linux

• Test 406 error at startup:

  • [x] Windows
  • [x] Mac
  • [x] Linux

• Test in the case the update was skipped (i.e., we are in 3.5.8, we skipped 3.6.0 but 3.5.8 is now banned, the 3.6.0 should be proposed on the locked screen):

  • [x] Windows
  • [x] Mac
  • [x] Linux (Not concerned)

[herve-er]

On Linux, there isn't a download button as the user need to download the new version on the website manually:

As There isn't a download button, I let the quit button in the icon menu:

(Synthesis open the upgrade required page)

[ClementKunz]

The style of the synthesis popover is not ok anymore on macOS

Same on Windows, only visible with dark mode. Working on it.

Fixed in this commit: 9bd6a65

[ClementKunz]

The app try to restart itself once Sparkle killed it, therefor displaying this message. Sparkle does not use the uninstaller so we need to find a different way to avoid that... Once all processed stopped, it is impossible to start the app. However, we can see in the ìnfo.plist` file that the version has been updated

[herve-er]

The app try to restart itself once Sparkle killed it, therefor displaying this message. Sparkle does not use the uninstaller so we need to find a different way to avoid that... Once all processed stopped, it is impossible to start the app. However, we can see in the ìnfo.plist` file that the version has been updated

Did you desactivate proxyman before tring to restart the app after the update? As 406 error is not retrocompatible, the 3.6.1 app crash at startup when receiving a 406.

For the Sparkle issue, I will think about it and come back.

[ClementKunz]

Did you desactivate proxyman before tring to restart the app after the update? As 406 error is not retrocompatible, the 3.6.1 app crash at startup when receiving a 406.

No I did not, good thinking 👍 But anyway it is another issue, a DB migration failure that should not happen. This is because we are currently building a 3.6.2 labelled as a 3.5.8

[sonarcloud[bot]]

Quality Gate passed

Issues
2 New issues
6 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud