Infomaniak / desktop-kDrive

:computer: Desktop Syncing Client for kDrive

GNU General Public License v3.0

30 stars 5 forks source link

Fix MoveToTrashFailed behaviour #390

Open herve-er opened 6 days ago

herve-er commented 6 days ago

Descritpion

This PR changes the behavior of the "Move to Trash" option for file deletion:

When the "Move to Trash" option is enabled, files are typically moved to the trash. New behavior: If moving the file to the trash fails, the file will be permanently deleted. This PR also includes a disclaimer to inform the user that the file may be irreversibly deleted if the move to trash operation fails.

UI/UX Modifications:

Settings -> Preferences:

MoveToTrash_settings

Conflicts

With "Move to Trash" enabled:

MoveToTrash_conflicts

With "Move to Trash" disabled:

warning_delete_conflicts

sonarcloud[bot] commented 5 days ago

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE