search

InfomediaLtd / angular2-materialize

Angular 2 support for Materialize CSS framework.
https://infomedialtd.github.io/angular2-materialize/
MIT License
407 stars 140 forks source link

In MaterializeAction replace [any] by any[] #411

Open Dakayl opened 6 years ago

Dakayl commented 6 years ago

Changing parameters type in MaterializeAction From [any] to any[].

[any] only has 1 element in its array. any[] can has multiple elements.

These are not equivalent.

Changing to any[] allows things like this.tabsActions.emit({action: "tabs", params: ['select_tab', page]}); that several persons were looking for, and it's compatible with previous versions.

theresaperez commented 6 years ago

How do I use this PR? Using npm install doesn't seem to work since I don't have proper rights. Thanks.

rubyboy commented 6 years ago

I'm more than happy to open this project for other contributors to maintain - please DM me if you're interested

Dakayl commented 6 years ago

Hi,

If i'm not alone in this, i would be happy to contribute.

2018-05-11 7:35 GMT+02:00 rubyboy notifications@github.com:

I'm more than happy to open this project for other contributors to maintain - please DM me if you're interested

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/InfomediaLtd/angular2-materialize/pull/411#issuecomment-388264672, or mute the thread https://github.com/notifications/unsubscribe-auth/ABN9mzOb72rcXGRh2LdGVwu2aCPEE0ugks5txSMNgaJpZM4SFTbS .

theresaperez commented 6 years ago

@rubyboy Thanks...I'm not looking to contribute. It looks like @Dakayl has already created a PR for what I need. I'm new to using other developers' github repos and want to know how to install or build this particular PR for angular2-materialize node package with this change (changing [any] to any[] for MaterialActions).

ParikshitChavan commented 6 years ago

Does this mean that we can now emit all the other functions different elements like

  1. addChip, deleteChip for chips
  2. setDate etc for datePickers if yes, is there documentation available anywhere?

Edit: Sorry, These functions are only available in Materialize 1.0.0