Informasjonsforvaltning / datacatalogtordf

A library that will map a data catalog (inkl dataset, dataservices and other dcat resources) to rdf
Apache License 2.0
5 stars 1 forks source link

Fix/dct identifier #32

Closed frederik-ronnevig closed 3 years ago

frederik-ronnevig commented 3 years ago

Etter samtale med @stigbd ble vi enige om følgende:

Vi innfører derfor ny property for alle klassene som iflg dcat-ap-no v2 har denne egenskapen.

https://github.com/Informasjonsforvaltning/datacatalogtordf/issues/25#issuecomment-817637316

codecov[bot] commented 3 years ago

Codecov Report

Merging #32 (6ca19e3) into master (b84ae64) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1339      1361   +22     
=========================================
+ Hits          1339      1361   +22     
Impacted Files Coverage Δ
src/datacatalogtordf/catalog.py 100.00% <100.00%> (ø)
src/datacatalogtordf/dataset.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b84ae64...6ca19e3. Read the comment docs.

frederik-ronnevig commented 3 years ago

Perfekt! Ein liten ting som må på plass: bump minor-version Tips: køyr følgande kommando % poetry version minor Evt manuelt endre version i pyproject.toml manuelt til

[tool.poetry]
name = "datacatalogtordf"
version = "1.3.0"
...

Takk for tilbakemelding @stigbd , da er det gjort! :-)

Fiffig å gjøre det med poetry! :+1: