Adding a DataService to a Catalog as a Dataset should give an error or warning

Informasjonsforvaltning / datacatalogtordf

A library that will map a data catalog (inkl dataset, dataservices and other dcat resources) to rdf

Apache License 2.0

5 stars 0 forks source link

Adding a DataService to a Catalog as a Dataset should give an error or warning #5

Closed sskagemo closed 2 years ago

sskagemo commented 4 years ago

After defining a DataService, if trying to add it to a catalog using Catalog.Dataset.append() should give an error or warning, as it leads to mismatch with the specification of range of dcat:dataset (dcat:Dataset) in the DCAT-standard

stigbd commented 2 years ago

After considering different approaches to this, I have come to the following:

Appending an element of wrong type, will raise an error by static type checkers, e.g. mypy
Enforcing runtime validation of appending element to the list adds complexity, and there seems to me to be that all possibilities will imply that static type checker no longer will raise error.

I therefore prefer to not support this at the moment, and encourage users to use static type checkers to sanitize their code.