search

InformaticsGenomicMedicine / DraftCoreDataModel

Draft of CoreDataModel
Apache License 2.0
0 stars 0 forks source link

Make some params optional #3

Closed rrfreimuth closed 1 year ago

rrfreimuth commented 1 year ago

https://github.com/InformaticsGenomicMedicine/DraftCoreDataModel/blob/79450932a44ee677816f9c02e6f5660ea03e5ec1/src/core_variant.py#L7-L9

These params should be optional: allelicState:str, geneSymbol:str hgncId:int

SalemBajjali commented 1 year ago

Made allelicState, geneSymbol and hgncid as optinal params: https://github.com/InformaticsGenomicMedicine/DraftCoreDataModel/blob/66f815799c6c614970c4caed71740a6bd41ce2e6/src/core_variant.py#L7-L10

SalemBajjali commented 1 year ago

Reviewed with @rrfreimuth.