search

InformaticsGenomicMedicine / DraftCoreDataModel

Draft of CoreDataModel
Apache License 2.0
0 stars 0 forks source link

Use "not in" operator #5

Closed rrfreimuth closed 1 year ago

rrfreimuth commented 1 year ago

https://github.com/InformaticsGenomicMedicine/DraftCoreDataModel/blob/79450932a44ee677816f9c02e6f5660ea03e5ec1/src/core_variant.py#L94C6-L94C6

Please change if not value in set to if value not in set. The first will work, but it is more pythonic to use the not in operator as documented here. Please change the linked conditional statement and then search the code for any others that need to be updated as well.

SalemBajjali commented 1 year ago

Changed syntax to "if value not in ..". Not going to highlight ever change but these changes were made in core_variant.py module that is currently in the issue-dev-sb branch.

SalemBajjali commented 1 year ago

Reviewed with @rrfreimuth.