Chemcentral table definitions are duplicated

InformaticsMatters / squonk

Squonk platform and computational notebook

Apache License 2.0

8 stars 3 forks source link

Chemcentral table definitions are duplicated #144

Closed tdudgeon closed 3 years ago

tdudgeon commented 3 years ago

They appear in components/rdkit-lib/src/main/groovy/org/squonk/rdkit/db/impl/ and components/rdkit-databases/src/main/groovy/org/squonk/rdkit/db/tables/. The second of these should not be needed as rdkit-databases has access to the rdkit-lib classes.

tdudgeon commented 3 years ago

Duplicate table definitions have been removed in the above commit.

All the loaders that are in use have been tested and run OK, with the caveat that the SDF loaders have to be run with the old squonk/chemcentral-loader:0.3.12 image due to current loader base image now running Java 11 and the javax.activation classes no longer being present. See #143 for details of this.