search

InformaticsMatters / squonk

Squonk platform and computational notebook
Apache License 2.0
8 stars 3 forks source link

UntrustedGroovyDatasetStepSpec nobbled if TRAVIS or CI is set #73

Open alanbchristie opened 5 years ago

alanbchristie commented 5 years ago

The changes for issue #72 have resulted in the tests defined in UntrustedGroovyDatasetStepSpec.groovy being disabled (if TRAVIS is defined). This is because the tests rely on access to /var/maven_repo - something not pleasant for Ci/CD.

We need to re-instate/fix/remove these tests.

alanbchristie commented 3 years ago

Current thinking is to remove the tests - they require some unpleasant capability - i.e. access to /var.

For now, if the Groovy tests fail, i.e. if you see these failures: -

org.squonk.execution.steps.impl.UntrustedGroovyDatasetStepSpec > simple copy dataset FAILED
    com.github.dockerjava.api.exception.NotFoundException at UntrustedGroovyDatasetStepSpec.groovy:85

org.squonk.execution.steps.impl.UntrustedGroovyDatasetStepSpec > groovy consumer FAILED
    com.github.dockerjava.api.exception.NotFoundException at UntrustedGroovyDatasetStepSpec.groovy:115

org.squonk.execution.steps.impl.UntrustedGroovyDatasetStepSpec > groovy function FAILED
    com.github.dockerjava.api.exception.NotFoundException at UntrustedGroovyDatasetStepSpec.groovy:150

Then simulate the CI environment and build like this...

$ CI=yes ./gradlew build