Informatievlaanderen / GIPOD

Generiek Informatie Platform Openbaar Domein
MIT License
9 stars 2 forks source link

Synergy-zone is not updated based on added or deleted groundworks #298

Open JoYsenbaardt opened 3 years ago

JoYsenbaardt commented 3 years ago

Describe the bug Synergy-zone is not updated based on added or deleted groundworks, we would expect that the synergy-zone is updated in that case. Example attatched (pdf en ppt).

Synergy zone not updated.pdf

Synergy zone not updated.pptx

olivermay commented 3 years ago

Hi Jo,

this is done by design because the synergy zone might be edited by the pilot, and by automatically updating it we might loose data entered by the pilot.

There is however a way to update the zone based on the groundwork zones easily when you edit the synergy: image

JoYsenbaardt commented 3 years ago

@olivermay Thanks for the clarification Oliver. Is this functionality also available in the API ?

olivermay commented 3 years ago

No, integrations can combine the zones, and update the synergy. This is the same way the GIPOD GUI integration does this.

JoYsenbaardt commented 3 years ago

Oliver, is this functionality already working in the GIPOD GUI ? On BETA we don't receive any geometry change after 'Synergiezone overnemen van GW' is executed and saved (example : SSYN 10499928)

olivermay commented 3 years ago

I tried this on Beta (https://gipod.beta-vlaanderen.be/samenwerking/synergie/10491030), and it seems to work. Don't forget to save the synergy after pressing the "Synergiezone overnemen van GW" button.

JoYsenbaardt commented 3 years ago

Oliver, your action didn't trigger any change. The added GW's do also not have the green background and the geometry has not changed. After the SAVE-action you will notice a error (screenshot in addition) Error after save.pptx

olivermay commented 3 years ago

That's clearly a bug, I'll pick it up tomorrow