Informatievlaanderen / OSLO-Standaardenregister

The new standards registry website using Webcomponents V3
MIT License
0 stars 0 forks source link

The end of a public review period is not present on the detail page #17

Closed KristofVDB1 closed 3 months ago

KristofVDB1 commented 6 months ago

Describe the bug Some older standards used to have a key called Einde publieke review. This is no longer present in the updated config file: https://github.com/Informatievlaanderen/OSLOthema-perceel/blob/standaardenregister/ap-percelen-config.json#L78C1-L79C1

To Reproduce Steps to reproduce the behavior: https://data.vlaanderen.be/standaarden/erkende-standaard/applicatieprofiel-dcat-ap-vl-2.0.html

Expected behavior Contain the data from the end of a public review period

Screenshots

Screenshot 2024-05-22 at 13 49 28
jitsedc commented 6 months ago

If possible it would be good to also capture the date for the start of a public review period too. This way this info is easily retrievable. Currently this info is only captured indirectly via the publication date of a specific version (in the URL) or via the reports of the working group (not easy to find and not always made publicly available).

KristofVDB1 commented 6 months ago

After a meeting with @bertvannuffelen, we decided to extend the config with a total of three extra dates:

We will keep track of these dates in the config files, but not show them immediately in the frontend. They will also be added to the config template so we don't forget them

KristofVDB1 commented 3 months ago

@jitsedc This has been added! Will close this issue for now. Feel free to reopen this if something related to this pops up again